-
Couldn't load subscription status.
- Fork 468
perf(tracer): improve performance of DefaultContextProvider #14920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 235 ± 2 ms. The average import time from base is: 237 ± 2 ms. The import time difference between this PR and base is: -1.93 ± 0.09 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate APMLP-474/improve.provider (830c62c) with baseline main (cc17dd5) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.402µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.2% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ add_inplace_aspectTime: ✅ 0.408µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.2% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ add_inplace_noaspectTime: ✅ 0.322µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +1.8% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 0.280µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +1.3% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ bytearray_aspectTime: ✅ 1.509µs (SLO: <10.000µs 📉 -84.9%) vs baseline: 📈 +11.8% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ bytearray_extend_aspectTime: ✅ 1.534µs (SLO: <10.000µs 📉 -84.7%) vs baseline: +2.3% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ bytearray_extend_noaspectTime: ✅ 0.620µs (SLO: <10.000µs 📉 -93.8%) vs baseline: +1.5% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ bytearray_noaspectTime: ✅ 0.488µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.9% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ bytes_aspectTime: ✅ 1.535µs (SLO: <10.000µs 📉 -84.6%) vs baseline: 📈 +19.0% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ bytes_noaspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.8% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.0% ✅ bytesio_aspectTime: ✅ 1.358µs (SLO: <10.000µs 📉 -86.4%) vs baseline: +0.5% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +4.9% ✅ bytesio_noaspectTime: ✅ 0.495µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -1.0% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ capitalize_aspectTime: ✅ 0.742µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +1.6% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.8% ✅ capitalize_noaspectTime: ✅ 0.439µs (SLO: <10.000µs 📉 -95.6%) vs baseline: -0.5% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ casefold_aspectTime: ✅ 0.744µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.4% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.8% ✅ casefold_noaspectTime: ✅ 0.372µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -1.1% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ decode_aspectTime: ✅ 0.724µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.5% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ decode_noaspectTime: ✅ 0.418µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -1.3% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.1% ✅ encode_aspectTime: ✅ 0.710µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.1% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.1% ✅ encode_noaspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.4% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ format_aspectTime: ✅ 3.557µs (SLO: <10.000µs 📉 -64.4%) vs baseline: +4.8% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ format_map_aspectTime: ✅ 4.176µs (SLO: <10.000µs 📉 -58.2%) vs baseline: 📈 +13.6% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ format_map_noaspectTime: ✅ 0.784µs (SLO: <10.000µs 📉 -92.2%) vs baseline: +1.2% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.8% ✅ format_noaspectTime: ✅ 0.598µs (SLO: <10.000µs 📉 -94.0%) vs baseline: ~same Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ index_aspectTime: ✅ 0.356µs (SLO: <10.000µs 📉 -96.4%) vs baseline: -0.7% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.0% ✅ index_noaspectTime: ✅ 0.274µs (SLO: <10.000µs 📉 -97.3%) vs baseline: -0.6% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ join_aspectTime: ✅ 1.362µs (SLO: <10.000µs 📉 -86.4%) vs baseline: +0.8% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 0.490µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.3% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.1% ✅ ljust_aspectTime: ✅ 2.586µs (SLO: <20.000µs 📉 -87.1%) vs baseline: +0.5% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.2% ✅ ljust_noaspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +1.1% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ lower_aspectTime: ✅ 2.328µs (SLO: <10.000µs 📉 -76.7%) vs baseline: +5.8% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ lower_noaspectTime: ✅ 0.374µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +1.2% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ lstrip_aspectTime: ✅ 2.517µs (SLO: <20.000µs 📉 -87.4%) vs baseline: 📈 +12.5% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ lstrip_noaspectTime: ✅ 0.379µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.3% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ modulo_aspectTime: ✅ 0.992µs (SLO: <10.000µs 📉 -90.1%) vs baseline: -0.3% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.8% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.562µs (SLO: <10.000µs 📉 -84.4%) vs baseline: ~same Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ modulo_aspect_for_bytesTime: ✅ 0.979µs (SLO: <10.000µs 📉 -90.2%) vs baseline: +0.3% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.233µs (SLO: <10.000µs 📉 -87.7%) vs baseline: ~same Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ modulo_noaspectTime: ✅ 0.626µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -1.7% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ replace_aspectTime: ✅ 4.946µs (SLO: <10.000µs 📉 -50.5%) vs baseline: -0.6% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ replace_noaspectTime: ✅ 0.464µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +1.0% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ repr_aspectTime: ✅ 0.911µs (SLO: <10.000µs 📉 -90.9%) vs baseline: +0.1% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ repr_noaspectTime: ✅ 0.412µs (SLO: <10.000µs 📉 -95.9%) vs baseline: ~same Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ rstrip_aspectTime: ✅ 1.914µs (SLO: <20.000µs 📉 -90.4%) vs baseline: +0.5% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ rstrip_noaspectTime: ✅ 0.385µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +1.4% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ slice_aspectTime: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.8% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ slice_noaspectTime: ✅ 0.451µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +0.9% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ stringio_aspectTime: ✅ 1.764µs (SLO: <10.000µs 📉 -82.4%) vs baseline: 📈 +11.8% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ stringio_noaspectTime: ✅ 0.726µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +1.3% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ strip_aspectTime: ✅ 2.213µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +0.2% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ strip_noaspectTime: ✅ 0.388µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.4% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.6% ✅ swapcase_aspectTime: ✅ 2.548µs (SLO: <10.000µs 📉 -74.5%) vs baseline: +5.9% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ swapcase_noaspectTime: ✅ 0.538µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +0.7% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ title_aspectTime: ✅ 2.330µs (SLO: <10.000µs 📉 -76.7%) vs baseline: -0.3% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ title_noaspectTime: ✅ 0.506µs (SLO: <10.000µs 📉 -94.9%) vs baseline: +0.9% Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ translate_aspectTime: ✅ 3.245µs (SLO: <10.000µs 📉 -67.5%) vs baseline: +0.3% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.9% ✅ translate_noaspectTime: ✅ 1.042µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +0.8% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +5.0% ✅ upper_aspectTime: ✅ 2.375µs (SLO: <10.000µs 📉 -76.2%) vs baseline: +7.8% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.8% ✅ upper_noaspectTime: ✅ 0.376µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +1.0% Memory: ✅ 38.024MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.240µs (SLO: <10.000µs 📉 -57.6%) vs baseline: +0.4% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +5.0% ✅ ospathbasename_noaspectTime: ✅ 1.087µs (SLO: <10.000µs 📉 -89.1%) vs baseline: +1.1% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ ospathjoin_aspectTime: ✅ 6.167µs (SLO: <10.000µs 📉 -38.3%) vs baseline: +0.3% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.7% ✅ ospathjoin_noaspectTime: ✅ 2.305µs (SLO: <10.000µs 📉 -76.9%) vs baseline: +0.8% Memory: ✅ 38.063MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ ospathnormcase_aspectTime: ✅ 3.871µs (SLO: <10.000µs 📉 -61.3%) vs baseline: 📈 +12.3% Memory: ✅ 38.142MB (SLO: <39.000MB -2.2%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 0.560µs (SLO: <10.000µs 📉 -94.4%) vs baseline: -1.5% Memory: ✅ 38.044MB (SLO: <39.000MB -2.5%) vs baseline: +4.6% ✅ ospathsplit_aspectTime: ✅ 4.793µs (SLO: <10.000µs 📉 -52.1%) vs baseline: ~same Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.7% ✅ ospathsplit_noaspectTime: ✅ 1.583µs (SLO: <10.000µs 📉 -84.2%) vs baseline: -0.9% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.7% ✅ ospathsplitdrive_aspectTime: ✅ 4.162µs (SLO: <10.000µs 📉 -58.4%) vs baseline: 📈 +14.6% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 0.694µs (SLO: <10.000µs 📉 -93.1%) vs baseline: -0.3% Memory: ✅ 38.103MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 4.558µs (SLO: <10.000µs 📉 -54.4%) vs baseline: +0.4% Memory: ✅ 38.083MB (SLO: <39.000MB -2.4%) vs baseline: +5.0% ✅ ospathsplitext_noaspectTime: ✅ 1.374µs (SLO: <10.000µs 📉 -86.3%) vs baseline: -0.8% Memory: ✅ 38.122MB (SLO: <39.000MB -2.3%) vs baseline: +4.9% 🟡 Near SLO Breach (3 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.427ms (SLO: <22.300ms -8.4%) vs baseline: ~same Memory: ✅ 65.254MB (SLO: <67.000MB -2.6%) vs baseline: +4.8% ✅ exception-replay-enabledTime: ✅ 1.342ms (SLO: <1.450ms -7.4%) vs baseline: -0.3% Memory: ✅ 64.556MB (SLO: <67.000MB -3.6%) vs baseline: +4.7% ✅ iastTime: ✅ 20.484ms (SLO: <22.250ms -7.9%) vs baseline: +0.2% Memory: ✅ 65.280MB (SLO: <67.000MB -2.6%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.696ms (SLO: <16.550ms -5.2%) vs baseline: +1.2% Memory: ✅ 54.045MB (SLO: <54.500MB 🟡 -0.8%) vs baseline: +4.7% ✅ resource-renamingTime: ✅ 20.569ms (SLO: <21.750ms -5.4%) vs baseline: ~same Memory: ✅ 65.352MB (SLO: <67.000MB -2.5%) vs baseline: +5.0% ✅ span-code-originTime: ✅ 25.314ms (SLO: <28.200ms 📉 -10.2%) vs baseline: -0.6% Memory: ✅ 68.760MB (SLO: <69.500MB 🟡 -1.1%) vs baseline: +6.5% ✅ tracerTime: ✅ 20.489ms (SLO: <21.750ms -5.8%) vs baseline: -0.6% Memory: ✅ 65.208MB (SLO: <67.000MB -2.7%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 22.679ms (SLO: <23.500ms -3.5%) vs baseline: +0.5% Memory: ✅ 66.724MB (SLO: <67.500MB 🟡 -1.1%) vs baseline: +4.8% ✅ tracer-dont-create-db-spansTime: ✅ 19.277ms (SLO: <21.500ms 📉 -10.3%) vs baseline: -0.4% Memory: ✅ 65.274MB (SLO: <66.000MB 🟡 -1.1%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.623ms (SLO: <17.500ms -5.0%) vs baseline: -0.2% Memory: ✅ 65.288MB (SLO: <66.000MB 🟡 -1.1%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 20.524ms (SLO: <21.750ms -5.6%) vs baseline: +0.2% Memory: ✅ 71.576MB (SLO: <72.500MB 🟡 -1.3%) vs baseline: +5.1% ✅ tracer-no-cachesTime: ✅ 18.484ms (SLO: <19.650ms -5.9%) vs baseline: +0.3% Memory: ✅ 65.210MB (SLO: <67.000MB -2.7%) vs baseline: +4.7% ✅ tracer-no-databasesTime: ✅ 18.812ms (SLO: <20.100ms -6.4%) vs baseline: ~same Memory: ✅ 65.208MB (SLO: <67.000MB -2.7%) vs baseline: +4.7% ✅ tracer-no-middlewareTime: ✅ 20.174ms (SLO: <21.500ms -6.2%) vs baseline: -0.1% Memory: ✅ 65.254MB (SLO: <67.000MB -2.6%) vs baseline: +4.8% ✅ tracer-no-templatesTime: ✅ 20.296ms (SLO: <22.000ms -7.7%) vs baseline: -0.2% Memory: ✅ 65.272MB (SLO: <67.000MB -2.6%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.108ms (SLO: <19.850ms -8.8%) vs baseline: ~same Memory: ✅ 65.251MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.165ms (SLO: <19.400ms -6.4%) vs baseline: +0.1% Memory: ✅ 65.251MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 18.040ms (SLO: <19.450ms -7.3%) vs baseline: ~same Memory: ✅ 65.205MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.580ms (SLO: <4.750ms -3.6%) vs baseline: ~same Memory: ✅ 61.951MB (SLO: <65.000MB -4.7%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.622ms (SLO: <6.750ms 🟡 -1.9%) vs baseline: -0.2% Memory: ✅ 62.024MB (SLO: <65.000MB -4.6%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.576ms (SLO: <4.750ms -3.7%) vs baseline: -0.1% Memory: ✅ 61.951MB (SLO: <65.000MB -4.7%) vs baseline: +4.7% ✅ debuggerTime: ✅ 1.857ms (SLO: <2.000ms -7.1%) vs baseline: +0.3% Memory: ✅ 45.298MB (SLO: <47.000MB -3.6%) vs baseline: +4.6% ✅ iast-getTime: ✅ 1.858ms (SLO: <2.000ms -7.1%) vs baseline: ~same Memory: ✅ 42.428MB (SLO: <49.000MB 📉 -13.4%) vs baseline: +5.1% ✅ profilerTime: ✅ 1.916ms (SLO: <2.100ms -8.8%) vs baseline: ~same Memory: ✅ 46.557MB (SLO: <47.000MB 🟡 -0.9%) vs baseline: +4.5% ✅ resource-renamingTime: ✅ 3.359ms (SLO: <3.650ms -8.0%) vs baseline: -0.2% Memory: ✅ 52.258MB (SLO: <53.500MB -2.3%) vs baseline: +4.9% ✅ tracerTime: ✅ 3.356ms (SLO: <3.650ms -8.0%) vs baseline: ~same Memory: ✅ 52.239MB (SLO: <53.500MB -2.4%) vs baseline: +5.1% ✅ tracer-nativeTime: ✅ 3.346ms (SLO: <3.650ms -8.3%) vs baseline: -0.3% Memory: ✅ 58.243MB (SLO: <60.000MB -2.9%) vs baseline: +5.0%
|
|
Small performance gain (~1%) in the tracer scenarios. |
## Description Two small tweaks to improve the overhead of DefaultContextProvider. - Replace `isinstance(item, Span) with `type(item) is Span` - Skip the `isinstance` check because we should only ever have this exact class and not a subclass - Remove calls to `Span.finished` which is a computed property ## Testing <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes <!-- Any other information that would be helpful for reviewers -->
Description
Two small tweaks to improve the overhead of DefaultContextProvider.
isinstance(item, Span) withtype(item) is Span`isinstancecheck because we should only ever have this exact class and not a subclassSpan.finishedwhich is a computed propertyTesting
Risks
Additional Notes